docs(component): added missing components to components page#15
Open
joesphchang wants to merge 17 commits intoperrygovier:mainfrom
Open
docs(component): added missing components to components page#15joesphchang wants to merge 17 commits intoperrygovier:mainfrom
joesphchang wants to merge 17 commits intoperrygovier:mainfrom
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…eam#4062) Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Author
|
Ok - I tried doing the way we did it before Perry but all the other commits stayed. |
perrygovier
requested changes
Jul 10, 2025
Owner
perrygovier
left a comment
perrygovier
left a comment
There was a problem hiding this comment.
Looks great! I left a few minor notes.
Owner
There was a problem hiding this comment.
Looks great! This will be a big improvement to that landing page. I left a few notes about some of the descriptions.
I'm open to discussion if you prefer to keep any of them as you have them.
Either way, after you make the changes, feel free to send this on to Ionic. If the PR includes other commits, back out, and let's try it together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3986
Changes I made
Utilized given screenshot to update components page.
Uploaded given photos into icons folder
Rearranged components page and wrote out description.