docs(config): added ionic-mode docs to Reading the Config"#7
Merged
perrygovier merged 1 commit intoperrygovier:mainfrom Jun 11, 2025
joesphchang:ionic-mode
Merged
docs(config): added ionic-mode docs to Reading the Config"#7perrygovier merged 1 commit intoperrygovier:mainfrom joesphchang:ionic-mode
perrygovier merged 1 commit intoperrygovier:mainfrom
joesphchang:ionic-mode
Conversation
Owner
|
This looks great to me. The ionic team might have opinions on best practices in the code examples that I'm not aware of, but this is working properly and is clean. Send it on over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things I did:
Issue that I resolved: #2580