Merged
Conversation
celian-garcia
force-pushed
the
fix/noprefix
branch
from
99370af to
6a7ee20
Compare
Signed-off-by: Celian GARCIA <celian.garcia@amadeus.com>
celian-garcia
force-pushed
the
fix/noprefix
branch
from
6a7ee20 to
ed4fc7a
Compare
Member
|
while I agree on the fix, I am wondering why you would end up by not giving a prefix actually. |
Member
Author
|
Personally, in some tests. But also I can imagine that someone deployed in a k8s pod don't see the point of prefixing if the environment is already scoped in a container. |
Member
Author
|
This is not a strong requirements, just I feel not elegant to have _ prefix by default. |
Nexucis
approved these changes
Feb 27, 2026
Member
Nexucis
left a comment
Nexucis
left a comment
There was a problem hiding this comment.
yeah I agree, if the code allows to have no prefix, then it should be handled correctly.
Thank you for the fix and the explanation on how you found this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that if we specify no prefix, the env variable taken should be in format "_FIELD1" instead of just "FIELD1".
This PR is here to fix it.