Add a builder for logrus and manage flag manually#328
Merged
Conversation
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Member
Author
|
/cc @ibakshay with this PR, we should be able to avoid the unnecessary flags in the MCP server |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is changing the way to manage the flag.
Before the flags were set in the init function. The issue was, even if you didn't use these flags, there were initialised anyway. So now these flags needs to be initialised manually by calling the function
InitFlagpresent in different packages.I have also taken the liberty to create a new builder to configure
logrus. I believe it will be a bit more flexible like that.