Restrict viewer.load() to only accept Table()
#1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
simple-viewer
branch
from
f174f0b to
ed134c4
Compare
sc1f
suggested changes
Oct 28, 2020
Contributor
There was a problem hiding this comment.
PerspectiveWidget is currently broken on this branch - verified locally and through code review.
Intuitively, we should also make sure that PerspectiveWidget follows this API change - i.e. it should only __init__ or load with a table and not a dataset.
texodus
force-pushed
the
simple-viewer
branch
2 times, most recently
from
a61dfc3 to
6ab05fa
Compare
texodus
force-pushed
the
simple-viewer
branch
from
6ab05fa to
5ca5061
Compare
timkpaine
reviewed
Jan 18, 2021
| */ | ||
| _update(data: TableData): void { | ||
| this.viewer.update(data); | ||
| this.viewer.table.update(data); |
Member
There was a problem hiding this comment.
TypeError: this.viewer.table is undefined
Member
There was a problem hiding this comment.
this introduces a bug as table isn't guaranteed to exist on the viewer. I don't think this was checked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
@finos/perspectiveas a build-time dependency of@finos/perspective-viewer, which in practice meansperspective.wasmWebAssembly binary and WebWorker JS runtime are no longer packed with the@finos/perspective-viewermodule, or any module that imports@finos/perspective-viewer. You must now also import@finos/perspectiveexplicitly.<perspective-viewer>'sload()method now only allows arguments of typeTable(), which must be created explicitly from a WebWorkerworker()or Websocketwebsocket().Table()methods on<perspective-viewer>have been removed:replace(),clear(),update(). Use e.g.viewer.table.clear()instead.