Skip to content

Conversation

@chenglou
Copy link
Contributor

No description provided.

@chenglou
Copy link
Contributor Author

A few issues:

  1. The output is in the out/ folder; I've included it because otherwise browserify throws upon path not found.
  2. uglifyjs fails if it's not globally installed already.
  3. React is a peer dependency (i.e. errors when different React versions are required by installed components). Doesn't do much for browserify but it might be useful in the future.
  4. Works right now for a single component, but npm dedupe is needed as soon as another component is installed (see above: browserify doesn't seem to check for peerDependency). I didn't include the script because that takes a bit of time and obstructs the watch workflow (same for collect-statics).
  5. Small issue & PR in the related repo.

Will do react-boilerplate after this and update README if this looks ok.

@petehunt
Copy link
Owner

Take a look at this: https://github.com/petehunt/generator-react-library/tree/master/app/templates

I think doing this all in Yeoman could make things a little easier. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants