Make a_filename const char* in Load/Save methods #2
Merged
peter-ch merged 1 commit intopeter-ch:masterfrom Nov 25, 2012
Merged
Conversation
This affects the Genome, NeuralNetwork, Parameters and Population, classes. Since a_filename is not modified by the Load/Save methods, it makes sense for it to be const. Having a_filename be const simplifies interaction with callers that use std::strings. The changes are backwards compatible - you can still pass a char* for a_filename.
Owner
|
Thank you, I'll try to merge your fixes now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affects the Genome, NeuralNetwork, Parameters and Population,
classes. Since a_filename is not modified by the Load/Save methods, it
makes sense for it to be const. Having a_filename be const simplifies
interaction with callers that use std::strings.
The changes are backwards compatible - you can still pass a char* for
a_filename.
Just thought I'd pass this along in case you want to make the package easier to use with std::string.c_str.
Thanks for a good library!