Fixes spaces in fractions causing invalid output (#435)#436
Merged
peterramsing merged 4 commits intopeterramsing:masterfrom Feb 9, 2019
Lucassifoni:master
Merged
Fixes spaces in fractions causing invalid output (#435)#436peterramsing merged 4 commits intopeterramsing:masterfrom Lucassifoni:master
peterramsing merged 4 commits intopeterramsing:masterfrom
Lucassifoni:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 742 758 +16
=====================================
+ Hits 742 758 +16
Continue to review full report at Codecov.
|
peterramsing
approved these changes
Feb 9, 2019
| * @param {string} str | ||
| * @returns {string} | ||
| */ | ||
| const glueFractionMembers = function glueFractionMembers(str) { |
| }); | ||
|
|
||
| it('generates valid output given spaces are present in the input', function() { | ||
| check( |
| var expect = require('chai').expect; | ||
| var utils = require('../lib/_lu-utilities.js'); | ||
|
|
||
| describe('glueFractionMembers', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change is this? (Bug Fix, Feature...)
Bug Fix of #435
Does this introduce any breaking changes?
No
Does the PR fulfill these requirements?
Other Comments
Hi @peterramsing ,
I fixed the bug in #435 , that was actually present in every lost declaration which syntax allows fractions. I fixed it with the smallest possible code change, but maybe working on a proper parser would avoid this whole class of bugs... I'll try to draft a grammar of lost's syntax when I'll be less busy.
I added tests for this bug, but did not update the docs, since this edit is meant to allow input slightly different from ideal, but not wrong in its meaning either.