Add key generation support#41
Closed
rnicoll wants to merge 1 commit intopetertodd:masterfrom
rnicoll:master-keygen
Closed
Add key generation support#41rnicoll wants to merge 1 commit intopetertodd:masterfrom rnicoll:master-keygen
rnicoll wants to merge 1 commit intopetertodd:masterfrom
rnicoll:master-keygen
Conversation
Owner
|
Have you seen the support in bitcoin.wallet for this functionality? bitcoin.core is meant to only contain consensus-critical code; ECDSA secret keys aren't consensus critical. |
Contributor
Author
|
I'm working on cross-chain transactions, so want to avoid key generation in bitcoind/dogecoind as it could lead to confusion. Given discussion in #39 it probably makes sense to close this, and I'll simply put the support into whatever altcoin lib I write instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for generating ECDSA keys, and for extracting just the secret bytes (as opposed to the full DER encoded private key) so that generated keys can be used to initialise CBitcoinSecret instances.