Port test improvements and db_version check refactor from #11256#147
Merged
peterwilsoncc merged 6 commits intopeterwilsoncc:collaboration/table-awareness-object-cachefrom May 6, 2026
Conversation
The database schema requirement is a system-level constraint, not a user preference. Move it from wp_is_collaboration_enabled() to wp_is_collaboration_allowed() where it belongs.
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Remove redundant DELETE in set_up() as transaction rollback handles cleanup. Use REST_TESTS_IMPOSSIBLY_HIGH_NUMBER for nonexistent post ID test.
Separate cron cleanup tests from the REST endpoint test file into tests/phpunit/tests/collaboration/collaborationCronCleanup.php.
Add message parameters to bare assertions for easier failure
identification. Replace update_option('db_version') with
pre_option_db_version filter so the value auto-restores on
test teardown.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
peterwilsoncc
approved these changes
May 6, 2026
Owner
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
There's a few things I'll probably change over the course of the day but I'll merge this in to my branch so I can get started with a test run.
Thank for this, much appreciated.
peterwilsoncc
merged commit 837fe7c
into
peterwilsoncc:collaboration/table-awareness-object-cache
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks recent test improvements and the db_version check refactor from WordPress#11256 onto the hybrid branch.
The cron cleanup move also pulled in
test_cron_cleanup_deletes_expired_awareness_rows(which you had added on this branch) — it referenced helpers being moved out, so it goes tocollaborationCronCleanup.phptoo. Otherwise it would have broken.Three commits from WordPress#11256 were skipped because their substance is already in this branch: the
collaboration_idrename, the stale-compaction-as-update fix, and PHPCS coding standards fixes.One commit (
4744b42918) has a generic GitHub-web-edit subject — happy to amend to something clearer if preferred.