Skip to content

Port benchmarks to criterion#19

Closed
vks wants to merge 4 commits intopetgraph:masterfrom
vks:criterion
Closed

Port benchmarks to criterion#19
vks wants to merge 4 commits intopetgraph:masterfrom
vks:criterion

Conversation

@vks
Copy link
Contributor

@vks vks commented Feb 22, 2018

This uses more solid statistics and works on stable.
A new benchmark with random bits has been added.

@bluss
Copy link
Member

bluss commented Feb 22, 2018

Cool. I don't think a port to criterion is worthwhile. Look at that swarm of deps it brings in (see travis).

@vks
Copy link
Contributor Author

vks commented Feb 22, 2018

Yes, but they are dev-dependencies. Anyway, it was useful for #18.

@vks
Copy link
Contributor Author

vks commented Feb 22, 2018

Criterion requires Rust 1.23, while fixedbitset works with 1.12. But the old benchmarks shouldn't work on any stable, so I'm a bit confused. I could make the criterion benchmarks a non-default feature, what do you think?

@bluss
Copy link
Member

bluss commented Feb 23, 2018

The maintainer has to make the decisions, that's what we are for. Adding 59 crates as dev-dependencies is a no-go, optional or not.

@bluss
Copy link
Member

bluss commented Feb 23, 2018

Thanks anyway. I'll just close this. I have had hopes that criterion would replace "bencher" but I wouldn't use it in this state. A lot of the crate looks awesome, of course.

@bluss bluss closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants