Closed
Conversation
Member
|
Cool. I don't think a port to criterion is worthwhile. Look at that swarm of deps it brings in (see travis). |
Contributor
Author
|
Yes, but they are dev-dependencies. Anyway, it was useful for #18. |
Contributor
Author
|
Criterion requires Rust 1.23, while fixedbitset works with 1.12. But the old benchmarks shouldn't work on any stable, so I'm a bit confused. I could make the criterion benchmarks a non-default feature, what do you think? |
Member
|
The maintainer has to make the decisions, that's what we are for. Adding 59 crates as dev-dependencies is a no-go, optional or not. |
Member
|
Thanks anyway. I'll just close this. I have had hopes that criterion would replace "bencher" but I wouldn't use it in this state. A lot of the crate looks awesome, of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses more solid statistics and works on stable.
A new benchmark with random bits has been added.