fix(compliance-audit): handle boolean false in settings checks

[don-petry]

Summary

The jq alternative operator (//) treats boolean false as falsy, so jq -r '.$key // "null"' returns "null" when the setting value is false. This causes any boolean-false check (e.g. has_wiki: false) to always fire as a finding, even when the repository setting is correctly set.

Before:

actual=$(echo "$settings" | jq -r ".$key // \"null\"")

After:

actual=$(echo "$settings" | jq -r ".$key | if . == null then \"null\" else tostring end")

This uses an explicit null guard and tostring conversion, so boolean false → "false" and boolean true → "true", while null still maps to "null".

Impact

• has_wiki: false no longer generates a false-positive finding for repos that already have wiki disabled
• All other boolean settings checks are also fixed (any future expected: false checks will work correctly)

Test plan

• Run the compliance audit after merging — bmad-bgreat-suite should no longer report has_wiki as a finding since its wiki is already disabled

Closes petry-projects/bmad-bgreat-suite#89

Generated with Claude Code

[don-petry]

@don-petry please review and merge — this fixes the false-positive compliance finding for has_wiki in bmad-bgreat-suite (and any other repo where a boolean-false setting is correctly applied).

[coderabbitai]

Warning

Rate limit exceeded

@don-petry has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 26 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 3 minutes and 26 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 49e35d33-a16d-4199-b17f-3c76d8d9e382

📥 Commits

Reviewing files that changed from the base of the PR and between d01423d and 8189f46.

📒 Files selected for processing (1)

• scripts/compliance-audit.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/compliance-audit-jq-boolean-false

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Fixes false-positive findings in the compliance audit’s repository settings checks by ensuring jq distinguishes between null and boolean false when extracting settings values.

Changes:

• Replace jq’s // "null" fallback with an explicit null guard plus tostring, so false is preserved as "false" instead of being treated like missing data.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.