fix(ci): move Dependabot exclusion to job-level if in claude-code-reusable.yml#136
fix(ci): move Dependabot exclusion to job-level if in claude-code-reusable.yml#136
Conversation
…sable.yml The claude job was reporting as failed on Dependabot PRs because the dependabot[bot] check was at the step level, causing the job to start but all steps to be skipped. GitHub marks such jobs as failed rather than skipped. Move the exclusion to the job-level if condition so the entire job is properly skipped. Also remove the now-redundant step-level if, and update AGENTS.md to describe the corrected behavior. Closes #135 Co-authored-by: don-petry <don-petry@users.noreply.github.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR relocates the Dependabot author check from a step-level Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Self-review complete — the diff is minimal and correct:
No edge cases missed. CI is green on all completed checks; CodeQL and SonarCloud still running. @don-petry — ready for your review and merge when CI is fully green. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the Claude Code reusable workflow so Dependabot PRs skip the entire claude job (instead of starting the job and skipping the key step), preventing GitHub from reporting an unintended failure and allowing required checks to be satisfied.
Changes:
- Moved the
dependabot[bot]exclusion from the “Run Claude Code” step-levelifto theclaudejob-levelifin the reusable workflow. - Removed the now-redundant step-level
ifon “Run Claude Code”. - Updated
AGENTS.mdto describe the corrected “job skipped” behavior for Dependabot PRs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
AGENTS.md |
Updates documentation to reflect that the Claude Code job (not just a step) is skipped for Dependabot PRs. |
.github/workflows/claude-code-reusable.yml |
Adjusts job-level conditional logic so the claude job is skipped for Dependabot PRs and no longer appears as failed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|



Summary
dependabot[bot]exclusion from the step-levelifon the "Run Claude Code" step to the job-levelifon theclaudejob in.github/workflows/claude-code-reusable.ymlifAGENTS.mdto accurately describe the corrected skip behaviorRoot cause
The
claudejob was starting on Dependabot PRs (the job-levelifdidn't exclude them), but the only meaningful step ("Run Claude Code") was gated by a step-levelif. With all steps either skipped or trivial, GitHub was marking the job as failed rather than skipped.Fix
Moving the exclusion condition to the job-level
ifcauses GitHub to mark the entire job as skipped, which satisfies required status checks without a failure signal.Closes #135
Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation