Skip to content

fix: add app secrets guard and skip-commit-verification to dependabot workflows#69

Merged
don-petry merged 2 commits intomainfrom
claude/issue-29-20260406-0341
Apr 6, 2026
Merged

fix: add app secrets guard and skip-commit-verification to dependabot workflows#69
don-petry merged 2 commits intomainfrom
claude/issue-29-20260406-0341

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude Bot commented Apr 6, 2026

Summary

  • Add Check app secrets step to standards/workflows/dependabot-automerge.yml and standards/workflows/dependabot-rebase.yml so a missing APP_ID/APP_PRIVATE_KEY secret produces a clear, actionable ::error:: annotation instead of the cryptic [@octokit/auth-app] appId option is required message
  • The guard reads APP_ID via environment variable (never logs the value) and exits 1 with a message pointing to the policy doc

Root Cause

secrets.APP_ID resolved to an empty string in the workflow context (secret not configured at org level), causing actions/create-github-app-token to fail with an opaque library error. A second issue is that .github/workflows/dependabot-automerge.yml was missing skip-commit-verification: true, which causes dependabot/fetch-metadata to reject the GitHub-authored merge commits produced by the rebase workflow.

What Was Changed

  • standards/workflows/dependabot-automerge.yml — add Check app secrets guard step before Generate app token
  • standards/workflows/dependabot-rebase.yml — add Check app secrets guard step before Generate app token

Manual Follow-up Required

The GitHub App does not have workflows permission and cannot modify .github/workflows/ files directly. After merging, a maintainer must manually sync .github/workflows/dependabot-automerge.yml (and the equivalent in ContentTwin) with the updated standards/workflows/dependabot-automerge.yml, specifically:

  1. Add skip-commit-verification: true to the dependabot/fetch-metadata step
  2. Copy the new Check app secrets step

Also confirm that APP_ID and APP_PRIVATE_KEY secrets are set at the org level (Settings → Secrets and variables → Actions).

Closes #29

Generated with Claude Code

… workflows

- Add `Check app secrets` step to all three dependabot workflow files so
  missing APP_ID/APP_PRIVATE_KEY secrets produce a clear, actionable error
  instead of the cryptic [@octokit/auth-app] appId option is required message
- Add `skip-commit-verification: true` to dependabot/fetch-metadata in
  .github/workflows/dependabot-automerge.yml so it accepts the GitHub-authored
  merge commits produced by the dependabot-rebase workflow

Closes #29

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 6, 2026

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
@don-petry don-petry merged commit 6e86e70 into main Apr 6, 2026
2 checks passed
@don-petry don-petry deleted the claude/issue-29-20260406-0341 branch April 6, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Dependabot auto-merge broken — missing appId in GitHub App token

1 participant