docs: update compliance status and add bash 4+ requirement#73
docs: update compliance status and add bash 4+ requirement#73
Conversation
- Update Current Compliance Status table: all repo settings are now fully compliant after bulk remediation; document remaining ruleset gaps - Add Bash 4+ requirement note to apply-repo-settings.sh (uses associative arrays, incompatible with macOS default Bash 3.2) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request adds a Bash version 4+ compatibility check to the apply-repo-settings script and updates documentation to reflect that all 7 repositories are fully compliant as of April 2026 following remediation. The documentation includes a new ruleset status table tracking pr-quality and code-quality rulesets across repositories. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates the organization standards documentation to reflect current repository compliance status and clarifies tooling requirements for the remediation script.
Changes:
- Refreshes
Current Compliance Statusto indicate all 7 repos are settings-compliant and adds a ruleset coverage matrix (pr-quality/code-quality). - Documents follow-up work needed for ruleset rollout, including migrating
google-app-scriptsfrom a legacy ruleset. - Adds an explicit Bash 4+ requirement note to
apply-repo-settings.shdue to associative array usage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| standards/github-settings.md | Updates compliance status and adds a ruleset coverage table plus next steps for ruleset rollout. |
| scripts/apply-repo-settings.sh | Documents Bash 4+ requirement in script header to match actual associative array usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses Copilot review: fail fast with actionable message instead of cryptic declare -A error on macOS Bash 3.2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
github-settings.md: all 7 repos are now fully compliant on settings after bulk remediation viaapply-repo-settings.sh --allpr-quality/code-qualityrulesets and which don't)google-app-scriptshas a non-standardprotect-branchesruleset needing migrationapply-repo-settings.shheader (usesdeclare -Aassociative arrays, incompatible with macOS default Bash 3.2)🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation