chore(security): remove drift codeql.yml, enable GitHub-managed default setup#107
chore(security): remove drift codeql.yml, enable GitHub-managed default setup#107
Conversation
…lt setup Per ci-standards.md §2, CodeQL should be configured via GitHub-managed default setup (Settings → Code security), not a per-repo workflow file. Per-repo codeql.yml files are treated as drift by the compliance audit. Enabled default setup via: gh api -X PATCH repos/petry-projects/TalkTerm/code-scanning/default-setup -F state=configured -F query_suite=default Closes #95 Co-authored-by: don-petry <don-petry@users.noreply.github.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 51 minutes and 44 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@don-petry — this PR is ready for review and merge. It fixes the CodeQL compliance finding by removing the drift |
|
There was a problem hiding this comment.
Pull request overview
Removes the repository-managed CodeQL workflow to align with org CI standards that require GitHub-managed CodeQL default setup (configured in repo settings rather than via workflow code).
Changes:
- Deleted
.github/workflows/codeql.yml(previous advanced CodeQL workflow). - Relies on GitHub’s Code Scanning default setup being configured (
state=configured,query_suite=default) outside the repo.
Comments suppressed due to low confidence (1)
.github/workflows/codeql.yml:1
- Deleting this workflow removes the CodeQL
actionslanguage scan (the workflow/pipeline security query pack). GitHub-managed CodeQL default setup typically scans only code languages (e.g., JS/TS) and does not include the GitHub Actions query suite; if Actions scanning is still desired, add a minimal dedicated workflow forlanguage: actions(or confirm the org standard explicitly accepts losing Actions scans).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Automated review — APPROVEDRisk: LOW
SummaryPR deletes a per-repo codeql.yml that the org CI standard §2 explicitly classifies as drift, and the out-of-band default-setup configuration claim is independently verifiable via the GitHub API: state=configured with languages=['actions','python'] and query_suite=default. CodeQL analysis records on refs/heads/main confirm both /language:actions and /language:python categories are actively running, so the 'actions' security scanning the deep review worried about is not lost — and python scanning is a net gain. The deep review's critical coverage-reduction finding was based on a conservative prior about default setup; empirical verification refutes it. FindingsInfo
Minor
CI statusAll status checks SUCCESS (CodeQL python+actions, SonarCloud 0 new issues / 0 hotspots, AgentShield, CodeRabbit). mergeStateStatus=BLOCKED due to branch protection requiring human reviewer approval (REVIEW_REQUIRED), not due to failing checks. Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with |



Summary
state=configured,query_suite=default)codeql.ymlworkflow file, which is classified as drift by the org CI standardsWhy
Per
ci-standards.md §2, CodeQL must be configured through GitHub's default setup (Settings → Code security), not via a per-repo workflow file. The standard explicitly states: "per-repocodeql.ymlfiles are treated as drift by the compliance audit."The existing
codeql.ymlwas an advanced setup that duplicated what GitHub's managed default setup provides automatically, including auto-detected languages and managed analyzer versions.Changes
.github/workflows/codeql.yml(drift per org standard)gh api -X PATCH repos/petry-projects/TalkTerm/code-scanning/default-setup -F state=configured -F query_suite=defaultCloses #95
Generated with Claude Code