Skip to content

chore(settings): add .github/settings.yml to codify repo settings#118

Open
don-petry wants to merge 2 commits intomainfrom
claude/issue-92-20260420-1033
Open

chore(settings): add .github/settings.yml to codify repo settings#118
don-petry wants to merge 2 commits intomainfrom
claude/issue-92-20260420-1033

Conversation

@don-petry
Copy link
Copy Markdown
Contributor

Summary

  • Adds .github/settings.yml documenting required repository settings per the petry-projects org standard
  • Re-applied delete_branch_on_merge: true via the GitHub API (confirmed active)
  • Codifies all merge settings, discussion, wiki, and issue tracking settings as infrastructure-as-code

Why a settings file?

Previous fixes (April 14, April 18) applied the setting via the GitHub API but left no code change in the repository. This PR creates an auditable, reviewable record of the intended settings in .github/settings.yml using the Probot GitHub Settings format — a widely-recognized standard. If the app is ever installed org-wide, enforcement becomes automatic. Until then, settings are applied via the org's apply-repo-settings.sh script.

Compliance

The delete_branch_on_merge setting is currently true in the GitHub API (re-verified and re-applied as part of this fix). The next weekly Friday audit should clear the finding.

Closes #92


Generated with Claude Code

Documents required repository settings per the petry-projects org standard
(standards/github-settings.md), including `delete_branch_on_merge: true`.

This creates an auditable, reviewable infrastructure-as-code record of the
intended settings. The Probot GitHub Settings app will enforce these
automatically if installed in the future; for now, settings are applied via
the GitHub API (apply-repo-settings.sh).

Closes #92

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 20, 2026 10:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 3 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 52 minutes and 3 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 171eb9b8-1faa-45e2-b004-d818ad951866

📥 Commits

Reviewing files that changed from the base of the PR and between 051f051 and 14128cf.

📒 Files selected for processing (1)
  • .github/settings.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-92-20260420-1033

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry
Copy link
Copy Markdown
Contributor Author

@don-petry this PR adds .github/settings.yml to codify the repository settings as infrastructure-as-code, fixing the delete_branch_on_merge compliance finding (issue #92). The setting has been re-applied via the GitHub API and confirmed true. Please review and merge when ready.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Probot GitHub Settings–format file to codify this repository’s GitHub settings in-repo, primarily to address compliance around delete_branch_on_merge and to make settings auditable.

Changes:

  • Adds .github/settings.yml describing required GitHub repository settings (issues/wiki/discussions + merge settings).
  • Codifies delete_branch_on_merge: true and squash merge commit formatting options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/settings.yml
Comment on lines +8 to +10
# These settings are enforced via the GitHub API (scripts/apply-repo-settings.sh).
# If the Probot GitHub Settings app is ever installed, this file will also
# automatically enforce them.
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment references scripts/apply-repo-settings.sh, but this repository doesn’t contain a scripts/ directory or that script. This is misleading for future maintainers—please update the comment to point at the actual location of the org script (or link to the standard/docs that describe how settings are applied).

Suggested change
# These settings are enforced via the GitHub API (scripts/apply-repo-settings.sh).
# If the Probot GitHub Settings app is ever installed, this file will also
# automatically enforce them.
# These settings are defined by the organization standard above and may be
# enforced automatically if the Probot GitHub Settings app is installed.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: delete_branch_on_merge

2 participants