Import org-wide AGENTS.md, remove duplicated standards#23
Conversation
References shared standards from petry-projects/.github for TDD, CI gates, PR reviews, security, and agent guidance. Keeps only project-specific content in this repo's CLAUDE.md. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 49 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates TalkTerm’s CLAUDE.md to reference centralized org-wide agent/development standards and reduce duplicated “generic” policy text, keeping this repo’s document focused on TalkTerm-specific guidance.
Changes:
- Adds references to
petry-projects/.github/AGENTS.mdas the source for shared org-wide standards. - Updates TDD / pre-commit / CI sections to explicitly extend org-wide standards while retaining project-specific configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Clarify that TalkTerm extends org-wide standards, not sole source of truth - Mark .claude/rules/ file references as planned but not yet created Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Follows the org convention where AGENTS.md is the comprehensive agent-agnostic file and CLAUDE.md is a Claude Code-specific summary with @import for org-wide standards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
AGENTS.md (2)
84-106: Add language specifier to the directory structure code block.The fenced code block should specify a language for proper syntax highlighting and tooling compatibility. Use
textorplaintextfor the directory tree structure.📝 Proposed fix
-``` +```text src/ shared/types/ DOMAIN LAYER (entities, value objects, domain events)Based on static analysis hint: fenced code blocks should have a language specified (MD040).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@AGENTS.md` around lines 84 - 106, The fenced directory-tree code block (starting with "src/" and listing entries like "shared/types/", "main/", "renderer/", "preload/") needs a language specifier for proper linting; update the opening backticks from ``` to ```text (or ```plaintext) so the block becomes ```text and leave the tree content unchanged.
227-237: Add language specifier to the npm scripts code block.The fenced code block should specify a language. Use
bashorshellfor shell commands.📝 Proposed fix
-``` +```bash npm test → vitest run npm run test:watch → vitestBased on static analysis hint: fenced code blocks should have a language specified (MD040).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@AGENTS.md` around lines 227 - 237, The fenced code block listing npm scripts (the lines starting with "npm test → vitest run", "npm run test:watch → vitest", etc.) is missing a language specifier; update the opening backticks for that block from ``` to ```bash (or ```shell) so the markdown code fence includes a language (fixes MD040).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CLAUDE.md`:
- Line 23: Update the docs to remove the contradiction between CLAUDE.md and
AGENTS.md by explicitly stating whether pre-commit checks run automatically via
Husky+lint-staged or must be run manually; either (A) change the CLAUDE.md entry
"Pre-commit checks run manually" to mention that Husky v9 + lint-staged v15 run
on every commit and keep the provided command as an alternative manual command,
or (B) if Husky isn't actually configured, update AGENTS.md to remove or
rephrase the Husky statement and note that contributors must run the command
chain (npm run lint && npm run format && npm run typecheck && npm test)
manually; make the change in CLAUDE.md and/or AGENTS.md so both files
consistently state the same workflow.
- Line 1: The CLAUDE.md file contains an invalid external directive
"@https://raw.githubusercontent.com/petry-projects/.github/main/AGENTS.md" which
Claude Code does not support; remove or replace this directive by either copying
the external AGENTS.md content into a local file and referencing it as a local
include (e.g., @./AGENTS.md), embedding the needed rules directly into CLAUDE.md
or .claude/rules/*.md, or switching to an MCP server reference if
available—update the directive accordingly so only supported include forms are
used.
---
Nitpick comments:
In `@AGENTS.md`:
- Around line 84-106: The fenced directory-tree code block (starting with "src/"
and listing entries like "shared/types/", "main/", "renderer/", "preload/")
needs a language specifier for proper linting; update the opening backticks from
``` to ```text (or ```plaintext) so the block becomes ```text and leave the tree
content unchanged.
- Around line 227-237: The fenced code block listing npm scripts (the lines
starting with "npm test → vitest run", "npm run test:watch → vitest", etc.) is
missing a language specifier; update the opening backticks for that block from
``` to ```bash (or ```shell) so the markdown code fence includes a language
(fixes MD040).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: faa0f87e-f2c9-49c2-a3ae-fc4f7722ae52
📒 Files selected for processing (2)
AGENTS.mdCLAUDE.md
| @@ -1,256 +1,25 @@ | |||
| # TalkTerm — Project Context & Implementation Rules | |||
| @https://raw.githubusercontent.com/petry-projects/.github/main/AGENTS.md | |||
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the correct syntax for Claude Code to reference external rule files or standards documents via URL?
💡 Result:
There is no direct syntax in Claude Code for referencing external rule files or standards documents via URL using a simple @URL or similar construct. The @ syntax is primarily for local files (@filename or @/path/to/file) and MCP resources (@server:protocol://resource/path). To reference external documents via URL: 1. Provide the URL in your prompt (e.g., "Follow the standards at https://example.com/rules.md"). Claude Code can use the WebFetch tool (with permission via WebFetch(domain:example.com)) to fetch and analyze the content, as it supports web pages and PDFs. 2. For standards documents hosted via MCP servers (e.g., docs or GitHub MCP), use @server:file://path/to/document after configuring the MCP server with claude mcp add. Local alternatives for rules/standards: - Add to CLAUDE.md or .claude/rules/*.md (auto-loaded). - Use skills (SKILL.md) or --append-system-prompt-file ./rules.txt. No official docs show a direct @https://... syntax; URLs trigger WebFetch when Claude needs content.
Citations:
- 1: https://stevekinney.com/courses/ai-development/referencing-files-in-claude-code
- 2: https://code.claude.com/docs/en/mcp
- 3: https://docs.claude.com/en/docs/agents-and-tools/tool-use/web-fetch-tool
- 4: https://code.claude.com/docs/en/permissions
- 5: https://mcpcat.io/guides/reference-other-files/
- 6: https://code.claude.com/docs/en/cli-reference
Remove or replace the invalid @https://... directive on line 1.
The @https://... syntax is not supported by Claude Code. The @ directive supports only local file references (@filename or @/path/to/file) and MCP server resources (@server:protocol://resource/path). If you need Claude Code to apply external standards from the referenced URL, either:
- Copy the content from the external AGENTS.md into a local file and reference it locally (e.g.,
@./AGENTS.md). - Add the external rules directly to CLAUDE.md or
.claude/rules/*.md(auto-loaded by Claude Code). - Use an MCP server if the repository is configured with one.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~1-~1: The official name of this software platform is spelled with a capital “H”.
Context: ...w.githubusercontent.com/petry-projects/.github/main/AGENTS.md # TalkTerm — Claude Cod...
(GITHUB)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CLAUDE.md` at line 1, The CLAUDE.md file contains an invalid external
directive
"@https://raw.githubusercontent.com/petry-projects/.github/main/AGENTS.md" which
Claude Code does not support; remove or replace this directive by either copying
the external AGENTS.md content into a local file and referencing it as a local
include (e.g., @./AGENTS.md), embedding the needed rules directly into CLAUDE.md
or .claude/rules/*.md, or switching to an MCP server reference if
available—update the directive accordingly so only supported include forms are
used.
| 3. **Mutation testing** — 80% minimum Stryker score | ||
| 4. **Clean Architecture** — dependencies point inward, never import outer from inner layers | ||
| 5. **DDD bounded contexts** — Agent, Storage, Security, Voice, Avatar, Overlay | ||
| 6. **Pre-commit checks run manually** — `npm run lint && npm run format && npm run typecheck && npm test` |
There was a problem hiding this comment.
Resolve inconsistency about pre-commit automation.
Line 23 states "Pre-commit checks run manually" and provides a command chain, but AGENTS.md line 139 states "Husky v9 + lint-staged v15 run on every commit (~15-40s total)", implying automatic pre-commit hooks are configured.
This creates confusion about whether developers need to run checks manually or if they run automatically via Husky. Please clarify and align the documentation.
Suggested resolutions
Option 1: If Husky is configured and runs automatically, update line 23:
-6. **Pre-commit checks run manually** — `npm run lint && npm run format && npm run typecheck && npm test`
+6. **Pre-commit checks run automatically via Husky** — or run manually: `npm run lint && npm run format && npm run typecheck && npm test`Option 2: If the project doesn't have Husky configured yet, update AGENTS.md line 137-139:
## 5. Pre-Commit Quality Checks
-> **Extends org-wide pre-commit standards.** Project-specific tooling below.
-
-Husky v9 + lint-staged v15 run on every commit (~15-40s total):
+> **Extends org-wide pre-commit standards.** Project-specific tooling below. (Husky setup planned)
+
+Run these checks manually before committing (~15-40s total):🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CLAUDE.md` at line 23, Update the docs to remove the contradiction between
CLAUDE.md and AGENTS.md by explicitly stating whether pre-commit checks run
automatically via Husky+lint-staged or must be run manually; either (A) change
the CLAUDE.md entry "Pre-commit checks run manually" to mention that Husky v9 +
lint-staged v15 run on every commit and keep the provided command as an
alternative manual command, or (B) if Husky isn't actually configured, update
AGENTS.md to remove or rephrase the Husky statement and note that contributors
must run the command chain (npm run lint && npm run format && npm run typecheck
&& npm test) manually; make the change in CLAUDE.md and/or AGENTS.md so both
files consistently state the same workflow.
Ensures Claude Code loads both org-wide and repo-specific agent guidelines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The @ import is a Claude Code feature that resolves GitHub blob URLs natively — raw.githubusercontent.com is unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Summary
Depends on
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit