Skip to content

fix(workflows): prettier formatting on feature-ideation cron comment#151

Merged
don-petry merged 1 commit intomainfrom
fix/lint-drift-on-main
Apr 8, 2026
Merged

fix(workflows): prettier formatting on feature-ideation cron comment#151
don-petry merged 1 commit intomainfrom
fix/lint-drift-on-main

Conversation

@don-petry
Copy link
Copy Markdown
Collaborator

Closes #150.

The canonical stub from petry-projects/.github/standards/workflows/ uses three spaces before the cron-line comment. Prettier collapses that to a single space, which made prettier --check fail in CI on main, breaking the CI Pipeline / build-and-test job.

Diff

-    - cron: '0 7 * * 5'   # Friday 07:00 UTC (3 AM EDT / 2 AM EST)
+    - cron: '0 7 * * 5' # Friday 07:00 UTC (3 AM EDT / 2 AM EST)

Test plan

  • npm run check clean locally
  • CI on this branch — build-and-test should pass

Follow-up

The canonical template in petry-projects/.github has the same multi-space alignment and will keep producing this drift for new adopters. Filing a small PR there to bring it in line with prettier defaults.

🤖 Generated with Claude Code

Closes #150.

The canonical stub from petry-projects/.github/standards/workflows/
uses three spaces before the cron-line comment. Prettier collapses
that to a single space, which made `prettier --check` fail in CI on
main, breaking the CI Pipeline / build-and-test job.

This applies the prettier-style fix locally so CI clears. The
canonical template in petry-projects/.github should be updated to
match (filed separately) so future adopters don't hit the same drift.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 8, 2026 16:52
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

Warning

Rate limit exceeded

@don-petry has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 56 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 56 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f7ed4923-7ae9-4fbd-86fb-4e6a073d4d01

📥 Commits

Reviewing files that changed from the base of the PR and between 09565c4 and b093ddc.

📒 Files selected for processing (1)
  • .github/workflows/feature-ideation.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lint-drift-on-main

Comment @coderabbitai help to get the list of available commands and usage tips.

don-petry pushed a commit to petry-projects/.github that referenced this pull request Apr 8, 2026
…stub

The canonical stub had three spaces aligning the comment after the cron
expression. Repos that run prettier in their lint chain (e.g.
google-app-scripts) hit a `prettier --check` failure on every fresh
adoption — see petry-projects/google-app-scripts#151. Bringing the
template in line with prettier defaults so future adopters don't drift.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@don-petry don-petry merged commit a71631f into main Apr 8, 2026
19 checks passed
@don-petry don-petry deleted the fix/lint-drift-on-main branch April 8, 2026 17:08
don-petry added a commit to petry-projects/.github that referenced this pull request Apr 8, 2026
* fix(workflows): address CodeRabbit suggestions deferred from #87

Closes #90.

1) agent-shield-reusable.yml — SKILL.md frontmatter regex now allows
   optional leading whitespace (`^[[:space:]]*name:` /
   `^[[:space:]]*description:`), so indented YAML keys (e.g. under a
   `metadata:` parent) are recognised as present. Previously the strict
   column-zero anchor missed them.

2) dependabot-rebase-reusable.yml — fix vacuous-truth merge gate.
   `[].statusCheckRollup[]? | ... | all(...)` returns true on an empty
   list (logical convention), which made a PR with no status checks
   appear "all green" and trigger an auto-merge. New gate also requires
   at least one COMPLETED check before merging, in addition to the
   existing all-pass and zero-pending requirements. Also collapses the
   three `gh pr view` calls into one round-trip via a shared $ROLLUP.

3) dependency-audit-reusable.yml — cargo audit no longer re-runs per
   workspace member. The new logic finds workspace roots (Cargo.toml
   files containing `[workspace]`) and audits them once each, then
   audits standalone crates whose dir is not under any workspace root.
   For a workspace with N members, that's 1 audit instead of N+1.

4) dependency-audit-reusable.yml — pip-audit now audits both
   pyproject.toml AND requirements.txt when both exist in the same
   directory (some projects ship pyproject for tooling and
   requirements.txt for pinned runtime deps). Previously the elif
   branch made requirements.txt unreachable.

All four were originally raised by CodeRabbit on #87
and intentionally deferred to keep that PR no-behavior-change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(workflows): single space before cron comment in feature-ideation stub

The canonical stub had three spaces aligning the comment after the cron
expression. Repos that run prettier in their lint chain (e.g.
google-app-scripts) hit a `prettier --check` failure on every fresh
adoption — see petry-projects/google-app-scripts#151. Bringing the
template in line with prettier defaults so future adopters don't drift.

---------

Co-authored-by: DJ <dj@Rachels-MacBook-Air.local>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: build-and-test failing on main — formatting/lint check

2 participants