ci: pin agent-shield reusable workflow to SHA#178
Conversation
|
@don-petry This PR is ready for your review and merge. It pins the |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Pull request overview
Pins the AgentShield reusable workflow reference to an immutable commit SHA to satisfy the org action-pinning compliance requirement and close the related audit finding (#154).
Changes:
- Updated
.github/workflows/agent-shield.ymlto use a full commit SHA instead of the@v1tag for the reusable workflow reference.
| jobs: | ||
| agent-shield: | ||
| uses: petry-projects/.github/.github/workflows/agent-shield-reusable.yml@v1 | ||
| uses: petry-projects/.github/.github/workflows/agent-shield-reusable.yml@ae9709f4466dec60a5733c9e7487f69dcd004e05 # v1 |
There was a problem hiding this comment.
The header comment states this stub "MUST NOT change" the uses: line and that the source of truth lives in petry-projects/.github/standards/workflows/agent-shield.yml, but this PR intentionally changes uses: to a pinned SHA. To avoid confusing future editors (and potential drift from the upstream standard), consider updating the header guidance to explicitly allow updating the ref for pinning, and/or syncing this change back to the upstream source-of-truth workflow.
Automated review — APPROVEDRisk: LOW SummaryThis PR pins the agent-shield reusable workflow from a mutable @v1 tag to a specific commit SHA, which is a security best-practice improvement that prevents supply-chain attacks via tag mutation. All CI checks (CodeQL, SonarCloud, AgentShield, Node.js tests, Playwright, dependency audit) are green. The change is exactly one line in one workflow file with no logic impact. FindingsInfo
CI statusAll CI checks green. mergeStateStatus is BLOCKED (awaiting required human review approval) but code is MERGEABLE. Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with |



Summary
petry-projects/.github/.github/workflows/agent-shield-reusable.ymlfrom@v1to@ae9709f4466dec60a5733c9e7487f69dcd004e05 # v1Changes
.github/workflows/agent-shield.yml: replaced@v1tag reference with the corresponding commit SHA (ae9709f4466dec60a5733c9e7487f69dcd004e05), keeping# v1as a human-readable comment per org convention.The SHA was resolved by dereferencing the annotated tag:
208ec2d69b75227d375edf8745d84fbac05a76b2ae9709f4466dec60a5733c9e7487f69dcd004e05Closes #154
Generated with Claude Code
Summary by CodeRabbit