Skip to content

fix: enable delete_branch_on_merge in settings.yml for compliance#217

Open
don-petry wants to merge 2 commits intomainfrom
claude/issue-164-20260419-2232
Open

fix: enable delete_branch_on_merge in settings.yml for compliance#217
don-petry wants to merge 2 commits intomainfrom
claude/issue-164-20260419-2232

Conversation

@don-petry
Copy link
Copy Markdown
Collaborator

Summary

  • Adds delete_branch_on_merge: true under the repository: section of .github/settings.yml
  • When probot/settings runs, it will declaratively enforce automatic head-branch deletion after every PR merge
  • Resolves the weekly compliance audit finding that has been open since this issue was filed

Background

Previous PRs #184 and #200 implemented the same fix but were not merged. This PR supersedes both. The GitHub API already returns delete_branch_on_merge: true (set manually), but without it in the declarative config, probot/settings could silently reset it on any future run.

Changes

  • .github/settings.yml: Added repository.delete_branch_on_merge: true

Closes #164

Generated with Claude Code

Add `delete_branch_on_merge: true` under the `repository:` section of
.github/settings.yml so probot/settings declaratively enforces automatic
head-branch deletion after every PR merge.

Closes #164

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 19, 2026 22:35
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 16 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 16 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 34017d09-8c81-45af-972d-011d701ed0b3

📥 Commits

Reviewing files that changed from the base of the PR and between 32e618b and 2fa1043.

📒 Files selected for processing (1)
  • .github/settings.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-164-20260419-2232

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry
Copy link
Copy Markdown
Collaborator Author

@don-petry — This PR is ready for review and merge.

What this does: Adds delete_branch_on_merge: true to .github/settings.yml so probot/settings declaratively enforces automatic head-branch deletion. This permanently resolves the compliance finding in #164.

Note: This supersedes the two earlier open PRs (#184 and #200) that made the identical change but were not merged. Once this PR is merged, you may close those as duplicates.

This is a config-only YAML change with no code impact — CI should pass cleanly.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a declarative repository setting to ensure Probot Settings enforces automatic deletion of head branches after PR merges, addressing the compliance finding in #164.

Changes:

  • Added a top-level repository: section to .github/settings.yml
  • Set repository.delete_branch_on_merge: true with an inline standards reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: delete_branch_on_merge

2 participants