Accept more foreign --platform "YOLO-mode" wheels.#2607
Merged
jsirois merged 2 commits intopex-tool:mainfrom Dec 2, 2024
Merged
Accept more foreign --platform "YOLO-mode" wheels.#2607jsirois merged 2 commits intopex-tool:mainfrom
--platform "YOLO-mode" wheels.#2607jsirois merged 2 commits intopex-tool:mainfrom
Conversation
Previously, when speculatively building a wheel from an sdist for a foreign platform target, the wheel tags needed to match the foreign platform target's tags exactly in all cases. For `--complete-platform` this makes sense, we have complete information about the foreign platform target's tags, but for an abbreviated `--platform` it does not since we have abbreviated information that is not enough to know a tag mismatch definitively signals the wheel will never work on the foreign platform target. Now only those definitive cases (e.g.: the speculative wheel is Linux but the foregin abbreviated platform is macOS) are rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when speculatively building a wheel from an sdist for a
foreign platform target, the wheel tags needed to match the foreign
platform target's tags exactly in all cases. For
--complete-platformthis makes sense, we have complete information about the foreign
platform target's tags, but for an abbreviated
--platformit does notsince we have abbreviated information that is not enough to know a tag
mismatch definitively signals the wheel will never work on the foreign
platform target. Now only those definitive cases (e.g.: the speculative
wheel is Linux but the foreign abbreviated platform is macOS) are
rejected. This will let some eventually failing wheels though, but the
warning added in #2533 already covers this risk.