Skip to content

Update --resolve-local-platforms docs.#2759

Merged
jsirois merged 1 commit intopex-tool:mainfrom
jsirois:resolve-local-platforms/fix-help
May 10, 2025
Merged

Update --resolve-local-platforms docs.#2759
jsirois merged 1 commit intopex-tool:mainfrom
jsirois:resolve-local-platforms/fix-help

Conversation

@jsirois
Copy link
Copy Markdown
Member

@jsirois jsirois commented May 10, 2025

These pre-dated --complete-platforms and now account for those.

These pre-dated `--complete-platform`s and now account for those.
@jsirois jsirois requested a review from huonw May 10, 2025 14:43
@jsirois
Copy link
Copy Markdown
Member Author

jsirois commented May 10, 2025

As noted here, these bad docs threw you off @huonw in one instance although it appears you read through these bad docs and actually used the option in combination with --complete-platform in Pants FAAS support in another instance. My brain does that all the time too.

Copy link
Copy Markdown
Collaborator

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.

Is there a way to turn off what you referred to elsewhere as "YOLO mode"? I.e., don't fall back to building on the interpreter executing pex, but require a local matching interpreter or fail fast?

@jsirois
Copy link
Copy Markdown
Member Author

jsirois commented May 10, 2025

Filling in history 1st off:

Is there a way to turn off what you referred to elsewhere as "YOLO mode"? I.e., don't fall back to building on the interpreter executing pex, but require a local matching interpreter or fail fast?

Sure, use --no-build. I will note this contradicts the Pants-internal decision made for FAAS where the combination of --complete-platform and --resolve-local-platforms is used to try to get a good result in as many situations as possible.

... I didn't read well. No. So you want --resolve-local-platforms {fail,fallback} where the current --resolve-local-platforms is --resolve-local-platforms fallback. That does not exist. Perhaps Pants could do the legwork on that one since its completely implementable in Pants as a search for a matching interpreter that fails or succeeds, and if it succeeds, uses that interpreter to run Pex. If Pants folks put in the work, discover that is actually useful and want to offload that work back into Pex, that sounds great. I've grown gunshy of implementing features for Pants though since they get adopted slowly or not at all.

@jsirois jsirois merged commit 4837d49 into pex-tool:main May 10, 2025
48 of 50 checks passed
@jsirois jsirois deleted the resolve-local-platforms/fix-help branch May 10, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants