Extend SearchParameters() in KeePassHttp.cs

[schmic]

Usually the URLs of an entry aren't stored in the title of the entry but in the URL-Field.
Currently that field isn't search, which should be changed.

Line #62 of KeePassHttp.cs:
p.SearchInUrls = true;

Thanks.

PS: Currently I'm not able to compile the plugin myself with:
....\keepass.exe --plgx-create KeePassHttp --plgx-prereq-kp:2.13 --plgx-prereq-net:3.5

Anything wrong with that? Thanks.

[pfn]

To compile, you need to specify the full path to keepasshttp for plgx-create... I hope dreichl fixes that in keepass...

I'll take a patch to search in urls, but don't really like it because the behavior will be a little strange due to the additional lookup in the url field and pattern matching... I'd prefer just domain name patterns be stored in the title only.

[jhuet]

I gotta agree with schmic, it seems a lot more natural to look for url field. I would even say than looking into title field should not be necessary.

Talking about pattern matching, how does the actual plugin matches URL ? Will a title field of 'http://github.com' will match an URL of 'https://github.com/login' ?

[pfn]

The semantics of the URL field is for a "bookmark" not for searching matching entries.

The Title field is a name for a given site, and does not strictly have to be a URL to match for passifox.

Given the way firefox works with its password manager, and how I've chosen to integrate into that password manager, passifox is not able to do full-URL matches against password requests. Only the host portion of a URL is inspected.

A title field of http://github.com, github.com, https://github.com, https://github.com/anythingatall will all match https://github.com/login/

Given this behavior, I can't justify matching against the URL field.

[jhuet]

Ok, i see your point. What i was trying to say, despite the fact that the URL field is designed for bookmarking is that people are more likely to put what the script is looking for to match the form URL into the URL field rather than in the Title field.

As an example it would have never come to my mind to put github.com in the Title field (i put Git Hub) but i did put github.com in the URL field.

Just my 2 cents ;)

[pfn]

ad5eae4

Ok, due to popular demand (well 3 or 4 of you, close enough ;-)) I decided to implement this.

It's in keepasshttp version 1.0.2.0,

Enjoy

[jhuet]

Thank you Perry :)