Skip to content

Comments

Add support for Vroom 1.11.0#25

Merged
krashish8 merged 45 commits intopgRouting:developfrom
krashish8:add-vroom-1.11-support
Dec 6, 2021
Merged

Add support for Vroom 1.11.0#25
krashish8 merged 45 commits intopgRouting:developfrom
krashish8:add-vroom-1.11-support

Conversation

@krashish8
Copy link
Member

@krashish8 krashish8 commented Dec 2, 2021

Fixes #24

Changes proposed in this pull request:

  • Added caching for VROOM in GitHub actions
  • Pump up VROOM version to 1.11.0
    • Add setup time in jobs and shipments to refine service time modeling
    • Add support for custom cost matrices, along with the duration matrix.
      • Using start_id, end_id, duration, cost as matrix table columns.
    • Add timeout and exploration_level parameters to vroom-category functions.
    • Add max_tasks column in vehicles.
    • Add tests for empty skills arrays.
    • Add custom scaling logic for speed_factor
  • Add Gehring & Homberger benchmark data for 1000 jobs: c1_10_1 (Not testing in CI, takes lot of time)
  • Honor client cancel requests for vroom-category functions.
  • Modify parameter names: index->id and internal changes of start_time -> tw_open, end_time -> tw_close.
  • Refined the documentation:
    • Separate INTEGER and TIMESTAMP/INTERVAL.
    • Add default values for all optional columns.
    • Update VROOM installation instructions, add the link in README
    • Update vrpRouting documentation link
  • Update release_notes and NEWS.

@pgRouting/admins

@krashish8 krashish8 added enhancement New feature or request vroom labels Dec 2, 2021
@krashish8 krashish8 added this to the Release 0.3.0 milestone Dec 2, 2021
@krashish8 krashish8 self-assigned this Dec 2, 2021
Copy link
Member Author

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvvergara I suppose that it is okay to add this line because anything can change on v0. So, signature change should not be an issue, right?

Or do we have to release a v1 if any signature changes on v0?

@krashish8 krashish8 requested review from a team, cvvergara and dkastl December 4, 2021 13:43
Copy link
Member

@dkastl dkastl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@krashish8 krashish8 force-pushed the add-vroom-1.11-support branch from 6455ccc to 38fd5fe Compare December 6, 2021 15:02
@krashish8 krashish8 force-pushed the add-vroom-1.11-support branch from 7ed4c27 to ad33d1e Compare December 6, 2021 20:17
@krashish8 krashish8 linked an issue Dec 6, 2021 that may be closed by this pull request
@krashish8 krashish8 merged commit 29f3000 into pgRouting:develop Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request vroom

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Vroom 1.11

2 participants