Skip to content

Separating implementation vroom#56

Merged
cvvergara merged 13 commits intopgRouting:mainfrom
cvvergara:separating-implementation-vroom
Aug 19, 2024
Merged

Separating implementation vroom#56
cvvergara merged 13 commits intopgRouting:mainfrom
cvvergara:separating-implementation-vroom

Conversation

@cvvergara
Copy link
Copy Markdown
Member

Changes proposed in this pull request:

  • Separated implementation from header
  • Substitute call to one liner function with the line
  • Remove unused code
  • Documenting only public functions

@pgRouting/admins

@cvvergara cvvergara added enhancement New feature or request vroom labels Aug 11, 2024
@cvvergara cvvergara added this to the Release 0.4.2 milestone Aug 11, 2024
@cvvergara cvvergara requested review from krashish8 and robe2 August 11, 2024 01:48
Copy link
Copy Markdown
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this!

@krashish8
Copy link
Copy Markdown
Member

Check Documentation is failing, but I'll leave it upto you - we can merge this.

@cvvergara
Copy link
Copy Markdown
Member Author

Yes the doxygen is failing since the update on the last PR, will fix soon

@cvvergara cvvergara merged commit 105e049 into pgRouting:main Aug 19, 2024
@cvvergara cvvergara deleted the separating-implementation-vroom branch August 19, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request vroom

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants