-
-
Notifications
You must be signed in to change notification settings - Fork 890
Feat: Add logic and test code for add_edge, add_directed_edges, add_undirected_edges methods of PDAG
#2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Docs: Added example comments to the `add_node` and `add_nodes_from` methods of the `ADMG` class. - Feat: In this process, `ADMG` was added to __init__.py so that the `DAG`, `PDAG`, and `ADMG` classes can be imported using `from pgmpy.base import`.
- The isort-enforced import order breaks the tests with a `TypeError`. - Reverting to the previous order fixes it.
…ected_edges` methods of `PDAG` (pgmpy#2311)
…ected_edges` methods of `PDAG` (pgmpy#2311)
|
This PR depends on PR Feat: Add logic and test code for |
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as in #2310 (review)
|
The methods related to |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2312 +/- ##
==========================================
+ Coverage 94.59% 95.02% +0.43%
==========================================
Files 149 158 +9
Lines 20155 22245 +2090
==========================================
+ Hits 19065 21138 +2073
- Misses 1090 1107 +17
|
Your checklist for this pull request
Please review the guidelines for contributing to this repository.
Issue number(s) that this pull request fixes
add_directed_edgesandadd_undirected_edgesmethods of thePDAGclass. #2311List of changes to the codebase in this pull request
add_edge,add_directed_edges,add_undirected_edgesmethods ofPDAGadd_edge,add_directed_edges,add_undirected_edgesmethods ofPDAG