ENH: Make ancestors method public for DAG and NaiveBayes model #2381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musab1Blaser
changed the title
ankurankan
requested changes
Oct 17, 2025
Member
ankurankan
left a comment
ankurankan
left a comment
There was a problem hiding this comment.
@Musab1Blaser I think everything looks good. Could you just change the name ancestors -> get_ancestors as we discussed in the issue?
Contributor
Author
|
@ankurankan sure, will do. Also, I think either my formatter or the repos auto formatter slightly reordered the import statements in the test file as can be seen. Should I create a new pr without this unnecessary change or leave it be and just make the discussed changes. |
ankurankan
approved these changes
Oct 17, 2025
Member
ankurankan
left a comment
ankurankan
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the PR @Musab1Blaser. @daehyun99 Any comments?
Contributor
|
@ankurankan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #2349
This PR makes changes
get_ancestors_oftoancestorsfor both DAG and NaiveBayes model, updating instances wherever called, including within tests.Issue number(s) that this pull request fixes
DAG._get_ancestors_oftoDAG.ancestors#2349List of changes to the codebase in this pull request