Skip to content

Conversation

@dacgray
Copy link
Contributor

@dacgray dacgray commented May 21, 2019

Hello!

  • Type: bug fix
  • issue:

#1162
This may be a better solution than #1255

We expect that setting --schema="" will not add setSchema() in initialize().

Please check if fix provides desired behaviour. If not I'll look into fixing #1255 ^^


In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Thanks

@dacgray dacgray changed the title 3.4.x fix: should not setSchema('foo') in initialize when we set --schema="" May 23, 2019
@dacgray
Copy link
Contributor Author

dacgray commented May 23, 2019

@Jeckerson

What do you say?

@Jeckerson
Copy link
Member

I'll check and tell you as soon as possible.

@Jeckerson
Copy link
Member

@dacgray Can you create separate tests without altering current? To make sure that script executing that line $schema = Utils::resolveDbSchema($config->database);

@dacgray dacgray force-pushed the 3.4.x branch 5 times, most recently from c017854 to 1b4d5aa Compare May 28, 2019 06:38
@dacgray
Copy link
Contributor Author

dacgray commented May 28, 2019

@Jeckerson @sergeyklay please take another look.

@dacgray
Copy link
Contributor Author

dacgray commented Jun 4, 2019

@Jeckerson @sergeyklay good to merge?

@Jeckerson Jeckerson merged commit c38a515 into phalcon:3.4.x Jun 4, 2019
@dacgray
Copy link
Contributor Author

dacgray commented Jun 10, 2019

@Jeckerson @sergeyklay is there anything I need to do, or do you have a timeline for a 3.4.2 release?

@Jeckerson
Copy link
Member

@dacgray https://github.com/phalcon/phalcon-devtools/milestone/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants