Skip to content

Conversation

@BeMySlaveDarlin
Copy link
Contributor

@BeMySlaveDarlin BeMySlaveDarlin commented Mar 22, 2021

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:
Fixed constants dropping in models when recreating with --force option: constants with access modifiers (public, protected, private) were ignored by preg_match pattern.
Fixed attributes duplication bug when recreating with --force option if no --camelize option declared and property is snake_cased.
Fixed column mapping on creation from table with PascalCase fields.

Thanks

@BeMySlaveDarlin BeMySlaveDarlin force-pushed the f/issue-1317-fix-force-creation-bugs branch from a295d7f to 5edf93e Compare March 22, 2021 21:04
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1498 (e249db0) into 4.0.x (e75d332) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           4.0.x   #1498      +/-   ##
========================================
+ Coverage   3.15%   3.16%   +0.01%     
========================================
  Files        111     111              
  Lines       5106    5079      -27     
========================================
  Hits         161     161              
+ Misses      4945    4918      -27     

@BeMySlaveDarlin BeMySlaveDarlin force-pushed the f/issue-1317-fix-force-creation-bugs branch from 449e684 to e249db0 Compare March 22, 2021 21:44
@Jeckerson Jeckerson merged commit 5111b27 into phalcon:4.0.x Mar 22, 2021
@BeMySlaveDarlin BeMySlaveDarlin deleted the f/issue-1317-fix-force-creation-bugs branch May 4, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants