Merge upstream/master - upgrade androidx.webkit:webkit to 1.14.0 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
commented
Sep 8, 2025
mmv08
commented
- Merged 16 commits from upstream/master
- Upgraded androidx.webkit:webkit from 1.4.0 to 1.14.0
- Added SSL error handling for sub-resources
- Added Payment Request API support (disabled downloads for security)
- Preserved Phantom's custom changes:
- Package name and version (1.0.2)
- Download blocking with toast message
- All existing security configurations
…webview#3743) * added support for light scroll indicators on iOS * rename prop, and cleaned * Update RNCWebViewManager.java --------- Co-authored-by: Roman Alifanov <roman@bbc.no> Co-authored-by: Thibault Malbranche <malbranche.thibault@gmail.com> Co-authored-by: Thibault Malbranche <thibault@brigad.co>
# [13.14.0](react-native-webview/react-native-webview@v13.13.5...v13.14.0) (2025-06-01) ### Features * **ios:** Added support for scrollview indicatorStyle ([react-native-webview#3743](react-native-webview#3743)) ([6af6a83](react-native-webview@6af6a83))
## [13.14.1](react-native-webview/react-native-webview@v13.14.0...v13.14.1) (2025-06-02) ### Bug Fixes * support react-native-codegen properly ([react-native-webview#3777](react-native-webview#3777)) ([823e6ae](react-native-webview@823e6ae))
## [13.14.2](react-native-webview/react-native-webview@v13.14.1...v13.14.2) (2025-06-07) ### Bug Fixes * **android:** suppressMenuItems native view config name with extra space ([react-native-webview#3780](react-native-webview#3780)) ([5a73948](react-native-webview@5a73948))
…t-native-webview#2278) (react-native-webview#3763) * feat(android) add support for enabling the Payment Request API * updated androidx.webkit:webkit version to 1.14.0-beta01 * updated androidx.webkit:webkit version to 1.14.0-rc01 * updated androidx.webkit:webkit version to 1.14.0
# [13.15.0](react-native-webview/react-native-webview@v13.14.2...v13.15.0) (2025-06-08) ### Features * **android:** add support for enabling the Payment Request API ([react-native-webview#2278](react-native-webview#2278)) ([react-native-webview#3763](react-native-webview#3763)) ([4ea6d6b](react-native-webview@4ea6d6b))
…native-webview#3834) * feat: add a handler for sub-resource SSL errors on Android * chore: add example for sub-resource SSL error handling * fix: make new prop optional
…ng (react-native-webview#3830) Hello, I'm working on a project where I'm creating a react-native native component that extends RNCWebView. When importing the `RNCWebView.h` header in my project the `==` operator will result in a symbol in my projects cocoapod target product. The same symbol will also be present in react-native-webviews cocoapods product, which causes a linker error like so: ``` ld: warning: ignoring duplicate libraries: '-lc++' duplicate symbol 'facebook::react::operator==(facebook::react::RNCWebViewMenuItemsStruct const&, facebook::react::RNCWebViewMenuItemsStruct const&)' in: /Users/ullrich/Library/Developer/Xcode/DerivedData/Example-geqgqakfnjrqhsbfipgqkrmgbtaw/Build/Products/Debug-iphonesimulator/pitch-mobile-webview/libpitch-mobile-webview.a[3](PitchWebview.o) /Users/ullrich/Library/Developer/Xcode/DerivedData/Example-geqgqakfnjrqhsbfipgqkrmgbtaw/Build/Products/Debug-iphonesimulator/react-native-webview/libreact-native-webview.a[4](RNCWebView.o) ld: 1 duplicate symbols clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` A simple solution to this is to inline this simple function. Thanks for considering this contribution 🙌
# [13.16.0](react-native-webview/react-native-webview@v13.15.0...v13.16.0) (2025-08-25) ### Bug Fixes * **android:** revert [react-native-webview#1221](react-native-webview#1221) setIgnoreErrFailedForThisURL ([react-native-webview#3831](react-native-webview#3831)) ([56989ca](react-native-webview@56989ca)) * **ios:** Inline CPP operator to avoid duplicate symbols during linking ([react-native-webview#3830](react-native-webview#3830)) ([2ee4218](react-native-webview@2ee4218)) * **types:** Make `clearCache` method required instead of optional ([react-native-webview#3818](react-native-webview#3818)) ([dd6fb80](react-native-webview@dd6fb80)) ### Features * **android:** Add sub resource SSL error handling on Android ([react-native-webview#3834](react-native-webview#3834)) ([8b96334](react-native-webview@8b96334))
- Merged 16 commits from upstream/master - Upgraded androidx.webkit:webkit from 1.4.0 to 1.14.0 - Added SSL error handling for sub-resources - Added Payment Request API support (disabled downloads for security) - Preserved Phantom's custom changes: - Package name and version (1.0.2) - Download blocking with toast message - All existing security configurations
Author
I tested the Android build locally on https://sandbox.phantom.dev/provider-doctor, and it seems to work |
- Changed the device name in the iOS CI workflow from 'iPhone 15' to 'iPhone 16'. - Updated the version of react-native-webview in Podfile.lock from 13.10.0 to 1.0.2 (our fork)
tian000
approved these changes
Sep 8, 2025
dan-phantom
approved these changes
Sep 8, 2025
jkadamczyk
approved these changes
Sep 8, 2025
gnash-phantom
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.