Update for GEllipse

[akevalion]

Added

• asPoint for GPoint
• fix GEllipse intersectionsWithLine: for empty ellipses
• Added class comment for GEllipse
• GRectangle now accepts empty rectangles
• remove manifest package tag

[jecisc]

In which case do you want a rectangle that is a point?

[jecisc]

I've checked and from the mathematical point of view a point cannot be considered as a rectangle.

[akevalion]

What is your reference? From my perspective, users can have empty shapes like an empty ellipse or empty rectangles, or empty polygons.

[jecisc]

I checked multiple sources such as Wikipedia, Wolfram, the dictionary...

All of them agree on "quadrilateral with opposite sides of equal lengths a and b, and with four right angles"

A point cannot have right angles. Thus, a point is not a rectangle.

[akevalion]

I rollback this method to its previous version

[jecisc]

For empty shapes, I would create a NullShape. For intersections, for example, it would always return an empty collection.

Or if your empty shape acts as a point, then I would use a point instead. IIRC points can react to #intersections:

[akevalion]

I will use points for that then.

[jecisc]

Oh, so the code managed ellispes without vertexes.

I think we are in the same case of the rectangle, those are not ellispses.

An ellipse is a curve that is the locus of all points in the plane the sum of whose distances r_1 and r_2 from two fixed points F_1 and F_2 (the foci) separated by a distance of 2c is a given positive constant 2a (Hilbert and Cohn-Vossen 1999, p. 2).

An ellipse needs a curve, which is not possible when there are no vertexes :(

[akevalion]

For roassal when shapes were empty I will use points

[akevalion]

Maybe the constructors of GRectangle and GEllipse can return a point instead of an error