Update version in #iceberg for BaselineOfPharo for Pharo 12 to ‘v2.3.4’ #18389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @Rinzwind, why in P13 we have ‘v2.3.2’ and in Pharo12 ‘v2.3.4’? |
Contributor
Author
Contributor
Author
|
@tesonep Could you maybe merge this? If you can first merge the two pull requests this depends on at least: libgit2-pharo-bindings pull request #101 and Iceberg pull request #1949. |
Contributor
Author
|
The tests that failed in build 3 for this pull request also failed in build 1575 of the ‘Pharo12’ job. |
Contributor
Author
Rinzwind
added a commit
to Rinzwind/pharo
that referenced
this pull request
Jul 24, 2025
…pharo12-iceberg Update version in #iceberg for BaselineOfPharo for Pharo 12 to ‘v2.3.4’
Contributor
Author
|
I don’t have permission to merge this though, perhaps because of the failing tests, as those are not related as far as I can tell, I tried directly pushing merge commits for this pull request and pull request #18388, but that didn’t work either. @tesonep @Ducasse @jecisc Could one of you maybe merge pull request #18388 and this one? |
Contributor
Author
|
@jecisc Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the version in #iceberg for BaselineOfPharo for Pharo 12 to ‘v2.3.4’.
Before merging this please: