Skip to content

Synchronising with changes made in Pharo repo a year and a half ago #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adri09070 merged 4 commits into from
Jul 8, 2022
Merged

Synchronising with changes made in Pharo repo a year and a half ago #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7db1b2b
Synchronising changes with Pharo repo so that testIsExecutionFinishe…
adri09070 Jul 8, 2022
1bc8a19
Merge 838471d881fb987b2e8394576bd6aab6ea2a7ef4
adri09070 Jul 8, 2022
33ff710
Formatting code and deleting obsolete comment
adri09070 Jul 8, 2022
72057cb
categorising method
adri09070 Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Sindarin-Tests/SindarinDebuggerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,15 +385,12 @@ SindarinDebuggerTest >> testIsAboutToInstantiateClass [

{ #category : #tests }
SindarinDebuggerTest >> testIsExecutionFinished [
"Test shows that the debugger is actually not correctly working and therefore it is disabled.
The fix requires the changes in #isExecutionFinished and on the Pharo side (PR#8567)
Once integrated there will be another PR here.
Projects are managed in different repos and therfore such complex integration"

| scdbg |
self skipOnPharoCITestingEnvironment.
scdbg := SindarinDebugger debug: [ self helperMethod16 ].
self deny: scdbg isExecutionFinished.

[ scdbg isExecutionFinished ] whileFalse: [ scdbg stepOver ].

self assert: scdbg currentProcess isTerminated
Expand Down
4 changes: 2 additions & 2 deletions Sindarin/SindarinDebugger.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ SindarinDebugger >> isAboutToSignalException [
SindarinDebugger >> isExecutionFinished [
"Returns whether the debugged execution is finished"

^ process isTerminating
^ process isTerminated
]

{ #category : #stackAccessHelpers }
Expand Down Expand Up @@ -382,7 +382,7 @@ SindarinDebugger >> openInGraphicalDebugger [
'Should be an extension of DebuggerSelector and handled by its sole instance'
]

{ #category : #'as yet unclassified' }
{ #category : #'accessing - context' }
SindarinDebugger >> outerMostContextOf: aContext [

| currentContext oldContext |
Expand Down