28 skip through and skip up to sometimes freeze the image when skipping in a block #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not reachable and so that it skips until we reach an implicit return or the aimed node if the aimed node is reachable. + tests
Collaborator
Author
|
I'm not sure of why there is a failing test for uncategorised methods while it doesn't say which method is uncategorized |
Collaborator
Author
|
It doesn't look like the failing tests are related as the two failing tests are on the issue tracker |
MarcusDenker
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28 and #13 . Needs pharo-project/pharo#11651 to be merged
When we used skipUpTo in a block to skip instructions, the image would freeze, even though it wouldn't if we had used skipUpTo to skip the same instructions outside of a block.
This is due to
skipUpTonot managing errors when the aimed node is not reachable (when, in the context of the node,context pcis greater than the last offset mapped to the aimed node.I fixed it so that skipUpTo doesn't skip anything when this is the case.
It also fixes #13 because, alongside my bunch of PRs improving the unitary skip, this PR makes the command much more stable. From what I've seen, my image doesn't freeze anymore when I use the command