compiling missing method when loading master or Pharo12 in P12, because it deletes a method from the entire system, while it should ONLY delete it from Sindarin #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se it deletes a method from the entire system, while it should ONLY delete it from Sindarin
Collaborator
Author
|
Unrelated failing tests |
Contributor
|
is this really a good idea to compile that method on the fly? |
Contributor
|
e.g. we could just backport it to Pharo10 |
Collaborator
Author
|
I don't really know, I don't really like the idea of compiling it on the fly but the only other solution was to load a package that contains only this method, that would be loaded only for Pharo12. But this looks too extreme for only one method. If you have a better solution, I'll go for it. I don't really see what you mean by "backport it" |
Contributor
|
Ah, I think I misunderstood. Yes, this is the simplest solution for now to compile the method |
Member
|
The failing test seems to not come from here. |
Collaborator
Author
Yes, this is ok |
Member
|
unrelated failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consequence of: #65 and fixes pharo-spec/NewTools#538