Skip to content

Remove unimplemented calls #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adri09070 merged 2 commits into from
Jul 31, 2023
Merged

Remove unimplemented calls #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25d4d1
Merge pull request #71 from pharo-spec/master
adri09070 May 25, 2023
f1cef0c
Remove unimplemented calls
jecisc Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/Sindarin-Tests/SindarinDebuggerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ SindarinDebuggerTest >> testChangingPcKeepsSameStateAndPushesCorrectElementsOnSt
SindarinDebuggerTest >> testChangingPcRaisesErrorWhenPcIsGreaterThanEndPC [

| oldPC sdbg |
sdbg := SindarinDebugger debug: [ self helperMethod1 ].
sdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
sdbg
step;
stepOver;
Expand All @@ -354,7 +354,7 @@ SindarinDebuggerTest >> testChangingPcRaisesErrorWhenPcIsGreaterThanEndPC [
self
shouldnt: [ sdbg pc: sdbg method endPC ] raise: NotValidPcError;
deny: sdbg pc equals: oldPC.
sdbg := SindarinDebugger debug: [ self helperMethod1 ].
sdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
sdbg
step;
stepOver;
Expand All @@ -369,7 +369,7 @@ SindarinDebuggerTest >> testChangingPcRaisesErrorWhenPcIsGreaterThanEndPC [
SindarinDebuggerTest >> testChangingPcRaisesErrorWhenPcIsLowerThanInitialPC [

| scdbg |
scdbg := SindarinDebugger debug: [ self helperMethod1 ].
scdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].

scdbg
step;
Expand All @@ -378,7 +378,7 @@ SindarinDebuggerTest >> testChangingPcRaisesErrorWhenPcIsLowerThanInitialPC [

self shouldnt: [ scdbg pc: scdbg method initialPC ] raise: NotValidPcError.

scdbg := SindarinDebugger debug: [ self helperMethod1 ].
scdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].

scdbg
step;
Expand Down Expand Up @@ -411,7 +411,7 @@ SindarinDebuggerTest >> testChangingPcToNonExistingBytecodeOffsetGoesToPreviousP
{ #category : #tests }
SindarinDebuggerTest >> testContext [
| scdbg |
scdbg := SindarinDebugger debug: [ self helperMethod15 ].
scdbg := SindarinDebugger debug: [ self methodWithOneAssignment ].
self assert: scdbg context equals: scdbg debugSession interruptedContext.
scdbg step.
self assert: scdbg context equals: scdbg debugSession interruptedContext
Expand Down Expand Up @@ -690,7 +690,7 @@ SindarinDebuggerTest >> testMoveToNodeKeepsStackWhenAimedNodeIsMethodNode [
SindarinDebuggerTest >> testMoveToNodeKeepsStackWhenAimedNodeIsMethodNodeThatDoesNotHaveAssociatedPC [

| scdbg newPc newNode realPC realNode |
scdbg := SindarinDebugger debug: [ self helperMethod1 ].
scdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].

scdbg
step;
Expand All @@ -717,7 +717,7 @@ SindarinDebuggerTest >> testMoveToNodeKeepsStackWhenAimedNodeIsMethodNodeThatDoe
SindarinDebuggerTest >> testMoveToNodeRaisesErrorWhenNodeIsNotIdenticalToANodeInMethod [

| oldNode sdbg aimedNode |
sdbg := SindarinDebugger debug: [ self helperMethod1 ].
sdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
sdbg
step;
stepOver.
Expand All @@ -729,7 +729,7 @@ SindarinDebuggerTest >> testMoveToNodeRaisesErrorWhenNodeIsNotIdenticalToANodeIn
self
shouldnt: [ sdbg moveToNode: aimedNode ] raise: NodeNotInASTError;
assert: sdbg node equals: aimedNode.
sdbg := SindarinDebugger debug: [ self helperMethod1 ].
sdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
sdbg
step;
stepOver;
Expand All @@ -745,7 +745,7 @@ SindarinDebuggerTest >> testMoveToNodeRaisesErrorWhenNodeIsNotIdenticalToANodeIn
SindarinDebuggerTest >> testMoveToNodeRaisesErrorWhenNodeIsNotInMethod [

| oldNode sdbg |
sdbg := SindarinDebugger debug: [ self helperMethod1 ].
sdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
sdbg
step;
stepOver;
Expand All @@ -755,7 +755,7 @@ SindarinDebuggerTest >> testMoveToNodeRaisesErrorWhenNodeIsNotInMethod [
shouldnt: [ sdbg moveToNode: sdbg methodNode statements last ]
raise: NodeNotInASTError;
deny: sdbg node equals: oldNode.
sdbg := SindarinDebugger debug: [ self helperMethod1 ].
sdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
sdbg
step;
stepOver;
Expand Down Expand Up @@ -1739,7 +1739,7 @@ SindarinDebuggerTest >> testStatementNodeContaining [
SindarinDebuggerTest >> testStatementNodeContainingReturnsStatementNodeThatContainsTheIdenticalSubtree [

| sdbg |
sdbg := SindarinDebugger debug: [ self helperMethod1 ].
sdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
sdbg step.

"1 is in the tree but it should return its parent only if we provide the exact literal node"
Expand All @@ -1752,7 +1752,7 @@ SindarinDebuggerTest >> testStatementNodeContainingReturnsStatementNodeThatConta
SindarinDebuggerTest >> testStatementNodeContainingWhenNodeIsNotInAST [

| sdbg |
sdbg := SindarinDebugger debug: [ self helperMethod1 ].
sdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
sdbg step.

self
Expand Down