Skip to content

Fix failing test in Pharo 12 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jecisc merged 2 commits into from
Feb 1, 2024
Merged

Fix failing test in Pharo 12 #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70ce297
Fix a failing test, thanks to @StevenCostiou
Feb 1, 2024
1269b4f
Fix another failing test: testIsExecutionFinished. Same way to previo…
Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Sindarin-Tests/SindarinDebuggerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,8 +506,10 @@ SindarinDebuggerTest >> testIsExecutionFinished [
scdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ].
self deny: scdbg isExecutionFinished.

[ scdbg isExecutionFinished ] whileFalse: [ scdbg stepOver ].

self
should: [ [ scdbg isExecutionFinished ] whileFalse: [ scdbg stepOver ] ]
raise: DebuggedExecutionIsFinished.

self assert: scdbg currentProcess isTerminated
]

Expand Down Expand Up @@ -1787,11 +1789,13 @@ SindarinDebuggerTest >> testStepOver [

{ #category : #tests }
SindarinDebuggerTest >> testStepOverFinishedExecution [
"This test tries to show is that using Sindarin on a block, it should raise an exception if you continue stepping over that code in your Sindarin script while the execution of that code is already finished (nothing more to step)"

|scdbg|
scdbg := SindarinDebugger debug: [ self methodWithImplicitReturn ].

"Stepping until the implicit return of #methodWithImplicitReturn"
scdbg stepOver: 3.
scdbg stepOver: 2.
self should: [scdbg stepOver] raise: DebuggedExecutionIsFinished
]

Expand Down