Skip to content

Fix testIsAboutToInstantiateClass #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarcusDenker merged 1 commit into from
Mar 29, 2024
Merged

Fix testIsAboutToInstantiateClass #91

MarcusDenker merged 1 commit into from
Mar 29, 2024

Conversation

@MarcusDenker
Copy link
Contributor

@MarcusDenker MarcusDenker commented Mar 29, 2024

fixes #87

@MarcusDenker MarcusDenker mentioned this pull request Mar 29, 2024
Merged
@MarcusDenker
Copy link
Contributor Author

MarcusDenker commented Mar 29, 2024

Running all tests has these failures:

✗ #testSlotOrVarLinksRemainAfterMethodModificationForObject (17ms)
✗ #testSlotOrVarLinksRemainAfterMethodModification (12ms)

SocketStreamTest
✗ #testFlushLargeMessageOtherEndClosed (3ms)

They are not caused be the change in this PR

@MarcusDenker MarcusDenker requested a review from adri09070 March 29, 2024 14:44
@MarcusDenker
Copy link
Contributor Author

MarcusDenker commented Mar 29, 2024

Duplicate of #90

@MarcusDenker MarcusDenker marked this as a duplicate of #90 Mar 29, 2024
@MarcusDenker MarcusDenker deleted the 87-update-SindarinDebuggerTesttestIsAboutToInstantiateClass branch March 29, 2024 14:45
@MarcusDenker MarcusDenker restored the 87-update-SindarinDebuggerTesttestIsAboutToInstantiateClass branch March 29, 2024 15:38
@MarcusDenker MarcusDenker reopened this Mar 29, 2024
@MarcusDenker
Copy link
Contributor Author

MarcusDenker commented Mar 29, 2024

I re-open this, as it was done against the Pharo12 brach. #90 was against master

  • I reverted 90
  • we can merge instead this one

@MarcusDenker MarcusDenker merged commit cbb8c08 into pharo-spec:Pharo12 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adri09070 adri09070 Awaiting requested review from adri09070

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MarcusDenker