[Pharo 13 backport] Backport speed up of Iceberg diff computation #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benefit of caching the writerClass is acknowledged in the comment of IceDiff>>#writerClass, but that implementation is not effective. The method #buildForChanges: will ultimately refer to the #writerClass of the source and target, and do so repeatedly, per changed file in the changes. I made this change by profiling the following expression ``` myRepository branch diffTo: myRepository workingCopy ``` where the active branch of the repository is different from the reference commit of the working copy. There are roughly a thousand items in the collection passed to #buildForChanges:. The duration drops from 9 to 6 seconds, more or less.
Contributor
Author
|
Since one of the PR has problems, I propose to backport only one of the improvements |
jecisc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to backport the recent 2 PRs to speedup iceberg. We could merge it and release after a few days of testing the new Pharo14 image