Improve the iceberg world menu #2007
Open
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jecisc
commented
Dec 9, 2025
jecisc
commented
- Use #ensureIsOpen instead of #open
- Merge IceTipRepositoriesBrowser class>>#menuCommandOn: and part of PharoCommonTools class>>#worldMenuOn:. This allow to cut a dependency from the core of Pharo to Iceberg. It's Iceberg that should declare its dependencies
- Fix a deprecation
- Use #ensureIsOpen instead of #open - Merge IceTipRepositoriesBrowser class>>#menuCommandOn: and part of PharoCommonTools class>>#worldMenuOn:. This allow to cut a dependency from the core of Pharo to Iceberg. It's Iceberg that should declare its dependencies - Fix a deprecation
jecisc
added a commit
to jecisc/pharo
that referenced
this pull request
Dec 9, 2025
I propose to moe the loading of Tool-Registry from BaselineOfMorphicCore to BaselineOfUIInfrastructure because it is not linked to Morphic but is used to build UIs. I also removed a dependency to Iceberg (It's moved here: pharo-vcs/iceberg#2007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.