Skip to content

Address some potential bugs in translations #22

@zepumph

Description

@zepumph

Over in phetsims/number-play#226, QA reported some spots that seemed pretty obvious to be a mistake. For example, where a parenthesis is opened but not closed, or there is a third template var curly brace. We spoke to @jbphet and he mentioned that just manually fixing these, if we feel very very confident of translator error, is totally fine.

So we did 98db64e

From that there are a couple of questions more generally (note that by searching in _generated_development_strings you don't search through history, and just current values of strings):

  • 2 usages {{{
  • 2 usage of }}}
  • 86 usages of ".*\([^)\n]*" (match an open paren that isn't closed), though we need to be careful about rtl languages here
  • 24 usages of "[^(\n]*\).*" (match a closed paren without an open), again worry about rtl languages and manually inspect things

@jbphet, does this seem like a worth while investigation?

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions