Open
Conversation
chrisminett
commented
Aug 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
============================================
+ Coverage 98.66% 98.69% +0.02%
- Complexity 362 366 +4
============================================
Files 41 41
Lines 1125 1146 +21
============================================
+ Hits 1110 1131 +21
Misses 15 15 ☔ View full report in Codecov by Sentry. |
chrisminett
force-pushed
the
managed-reset
branch
from
f87e3f7 to
1561478
Compare
# Conflicts: # src/Pool/ManagedConnection.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Pulled in from ng branch).
Plan to hold this change until after #3 is live in v3 to limit the behaviour changes – keeping the connection behaviour the same through all the refactoring.