Skip to content

Fix compatibility with ElasticMQ#19

Merged
Xnopyt merged 1 commit intophlib:mainfrom
Xnopyt:elasticmq
Mar 3, 2026
Merged

Fix compatibility with ElasticMQ#19
Xnopyt merged 1 commit intophlib:mainfrom
Xnopyt:elasticmq

Conversation

@Xnopyt
Copy link
Collaborator

@Xnopyt Xnopyt commented Mar 3, 2026

This PR changes the Phlib\JobQueue\AwsSqs\JobQueue so it is compatible with ElasticMQ, which is a message queue server which is compatible with AWS SQS.

The only difference with ElasticMQ that seems to affect this library is that receiving from an empty queue will result in an empty $result['Messages'] array whereas AWS will not return the Messages property in the response at all. Funnily, this looks to be a better implementation of the AWS spec than AWS managed, as the spec specifies that the Messages array will always be in the response and does not mark it as optional.

@Xnopyt Xnopyt added the patch-version Release CAN be patch version increment label Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.16%. Comparing base (ad4e670) to head (e89348f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #19   +/-   ##
=========================================
  Coverage     69.16%   69.16%           
  Complexity      141      141           
=========================================
  Files            10       10           
  Lines           467      467           
=========================================
  Hits            323      323           
  Misses          144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Xnopyt Xnopyt merged commit 04c108c into phlib:main Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch-version Release CAN be patch version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants