Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=========================================
Coverage 69.16% 69.16%
Complexity 141 141
=========================================
Files 10 10
Lines 467 467
=========================================
Hits 323 323
Misses 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amaanhassim
approved these changes
Mar 3, 2026
chrisminett
reviewed
Mar 3, 2026
chrisminett
requested changes
Mar 3, 2026
chrisminett
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
Phlib\JobQueue\AwsSqs\JobQueueso it is compatible with ElasticMQ, which is a message queue server which is compatible with AWS SQS.The only difference with ElasticMQ that seems to affect this library is that receiving from an empty queue will result in an empty
$result['Messages']array whereas AWS will not return theMessagesproperty in the response at all. Funnily, this looks to be a better implementation of the AWS spec than AWS managed, as the spec specifies that theMessagesarray will always be in the response and does not mark it as optional.