fix: straddle message bug#6
Conversation
|
Thanks @atymic ! I'll have a look at this in the next week or so. I've been going through the Phlib repos to upgrade them to minimum PHP 7.3 so I'll do this one next, including adding the CI tests which don't appear to have run here. |
|
No worries, it did actually run because i got emails from travis haha. |
|
Want me to PR bump to 7.3 and github actions CI? |
| ['', '7-bit', 0, 1, 160] | ||
| ['', '7-bit', 0, 1, 160], | ||
|
|
||
| [ |
There was a problem hiding this comment.
Could you add a comment explaining what the test is checking, please? Something which explains the value, like in #1 would be great:
The '[' at character 152 will become "0x1B[" (2 characters), and become part of the 2nd message, which pushes the last "." at the end of the content into a 3rd message
|
@atymic I've done all the code style changes I wanted to get done. Could you please rebase your changes from Love the check for the modulo! 🚀 |
|
See #8 Someone your changes to the repo broke my local git to the point where I could not push at all! Had to delete fork and re-pr |
Closes #1
Maybe worth some further tests as well, once merged i'll check the trucate PR works as expected