This repository was archived by the owner on Aug 17, 2025. It is now read-only.
Update getIdentifier function to support $id = 0#116
Closed
Wilt wants to merge 2 commits into
Closed
Conversation
added 2 commits
October 18, 2013 17:31
Update getIdentifier function to support $id = 0 Changed if clause to explicitly check for $id not being false. Previously when $id is set to int 0 the getIdentifier function results in returning false which is wrong. It should return the integer 0.
$identiferName -> $identifierName
Contributor
|
Fixed with #108. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update getIdentifier function to support $id = 0
Changed if clause to explicitly check for $id not being false.
Previously when $id is set to int 0 the getIdentifier function results
in returning false which is wrong. It should return the integer 0.