Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

remove unused variable#2467

Merged
macdonst merged 1 commit intophonegap:masterfrom
cordova-develop:remove_unnecessary_codes
Aug 14, 2018
Merged

remove unused variable#2467
macdonst merged 1 commit intophonegap:masterfrom
cordova-develop:remove_unnecessary_codes

Conversation

@knight9999
Copy link
Copy Markdown
Collaborator

Description

This PR is simply removing unnecessary codes from PushPlugin.m.

Related Issue

None

Motivation and Context

The plugin looks more complicacted because of unnecessary codes.

How Has This Been Tested?

I tests as follows.

  1. getting registration id.
  2. receive notification when app is background.
  3. receive notification when app is foreground.
  4. receive silent notification when app is background.
  5. receive silent notification when app is foreground.

All functions work well as before.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@macdonst macdonst added this to the Release 3.0.0 milestone Aug 2, 2018
@macdonst macdonst merged commit d5d2e9d into phonegap:master Aug 14, 2018
@lock
Copy link
Copy Markdown

lock bot commented Sep 13, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants