cli/command: ps: only check format-template once #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@photra ptal; if you agree with these changes, and merge this PR, it will be included in your PR |
photra
requested changes
Jun 7, 2022
Owner
|
Hi @thaJeztah, I just made some suggestions to above for conciseness. Please let me know what you think about it! 😁 |
thaJeztah
force-pushed
the
3632_fix_ps_format_suggestions
branch
from
9d1b7a0 to
c51ef56
Compare
Author
|
@photra I pushed a change; added one extra commit in which I fixed the logic in |
thaJeztah
commented
Jun 7, 2022
- do an early check if a custom format is specified either through the command-line, or through the cli's configuration, before adjusting the options (to add "size" if needed). - if no format is set after this, set the default (formatter.TableFormatKey) - also removes a redundant `options.Size = opts.size` line, as this value is already copied at the start of buildContainerListOptions() - Update NewContainerFormat to use "table" format as a default if no format was given. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
3632_fix_ps_format_suggestions
branch
from
c51ef56 to
94fd3d9
Compare
Author
|
Actually, perhaps we should do the last commit as a follow-up for visibility; let me remove it for now (and I can push it as a separate PR); possibly it needs discussion as there will be a slight change in behavior, which may need discussion. I removed the commit, and included some of the change in the existing one 👍 |
Owner
|
Gotcha, merging this PR now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command-line, or through the cli's configuration, before adjusting
the options (to add "size" if needed).
options.Size = opts.sizeline, as this value isalready copied at the start of buildContainerListOptions()