Skip to content

Fix SCC AllowPrivilegeEscalation Tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
php-coder merged 3 commits into from
Mar 22, 2018
Merged

Fix SCC AllowPrivilegeEscalation Tests #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fef784
undo test hacks
enj Mar 22, 2018
6ae744f
add correct test hacks
enj Mar 22, 2018
0e90bed
generate updated v1 code
enj Mar 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pkg/api/serialization_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,9 @@ func originFuzzer(t *testing.T, seed int64) *fuzz.Fuzzer {
scc.SupplementalGroups.Type = supGroupTypes[c.Rand.Intn(len(supGroupTypes))]
fsGroupTypes := []securityapi.FSGroupStrategyType{securityapi.FSGroupStrategyMustRunAs, securityapi.FSGroupStrategyRunAsAny}
scc.FSGroup.Type = fsGroupTypes[c.Rand.Intn(len(fsGroupTypes))]
// avoid the defaulting logic for this field by making it never nil
allowPrivilegeEscalation := c.RandBool()
scc.AllowPrivilegeEscalation = &allowPrivilegeEscalation

// when fuzzing the volume types ensure it is set to avoid the defaulter's expansion.
// Do not use FSTypeAll or host dir setting to steer clear of defaulting mechanics
Expand All @@ -532,11 +535,6 @@ func originFuzzer(t *testing.T, seed int64) *fuzz.Fuzzer {
securityapi.FSTypeRBD,
securityapi.FSTypeSecret}
scc.Volumes = []securityapi.FSType{volumeTypes[c.Rand.Intn(len(volumeTypes))]}

// match to the defaulting logic that is used to be backward compatible
yes := true
scc.AllowPrivilegeEscalation = &yes
scc.DefaultAllowPrivilegeEscalation = nil
},
)
return f
Expand Down
Loading