Skip to content

Mark testSumObjectCasting as incomplete (for Map and Set) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simPod wants to merge 1 commit into from
Closed

Mark testSumObjectCasting as incomplete (for Map and Set) #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/Map/sum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ public function testSum($values, $expected)

public function testSumObjectCasting()
{
$this->markTestIncomplete(<<<TEXT
Polyfill implementation is unable to convert gmp_init(42) to 42.
Ext's ADD_TO_SUM https://github.com/php-ds/ext-ds/blob/2ddef84d3e9391c37599cb716592184315e23921/src/common.h#L87 is similar to PHP_FUNCTION(array_sum) https://github.com/php/php-src/blob/34f727e63716dfb798865289c079b017812ad03b/ext/standard/array.c#L5868 that is called within polyfill.
Both call convert_scalar_to_number().
TEXT
);

if ( ! extension_loaded('gmp')) {
$this->markTestSkipped("GMP extension is not installed");
return;
Expand Down
7 changes: 7 additions & 0 deletions tests/Set/sum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ public function testSum($values, $expected)

public function testSumObjectCasting()
{
$this->markTestIncomplete(<<<TEXT
Polyfill implementation is unable to convert gmp_init(42) to 42.
Ext's ADD_TO_SUM https://github.com/php-ds/ext-ds/blob/2ddef84d3e9391c37599cb716592184315e23921/src/common.h#L87 is similar to PHP_FUNCTION(array_sum) https://github.com/php/php-src/blob/34f727e63716dfb798865289c079b017812ad03b/ext/standard/array.c#L5868 that is called within polyfill.
Both call convert_scalar_to_number().
TEXT
);

if ( ! extension_loaded('gmp')) {
$this->markTestSkipped("GMP extension is not installed");
return;
Expand Down